Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary buckets and window operator parsing algorithm #1111

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

ThomasQuesadilla
Copy link
Collaborator

@ThomasQuesadilla ThomasQuesadilla commented Nov 15, 2023

Includes the definition for summary window operator and summary bucket structure.


Preview | Diff

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 29, 2023
WICG/attribution-reporting-api#1111

But do not use them yet. This will make it easier to experiment with
proofs-of-concept for Full Flex prioritization, e.g.
crrev.com/c/5037210, after which we will start using these new functions
in TriggerSpecs::Parse().

This change has no effect on web-visible behavior.

OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError8]=Replaced by Conversions.SourceRegistrationError9

Bug: 1504219
Change-Id: I78fbcc62071a2b56051e07811ff5ded0d58b2e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5049377
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1230803}
Copy link
Collaborator

@apasel422 apasel422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update with respect to #1116.

@apasel422 apasel422 added the flexible-event Regarding the flexible event configuration proposal label Dec 1, 2023
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@ThomasQuesadilla ThomasQuesadilla merged commit e86d522 into main Dec 4, 2023
2 checks passed
@ThomasQuesadilla ThomasQuesadilla deleted the summary-buckets branch December 5, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flexible-event Regarding the flexible event configuration proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants