-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary buckets and window operator parsing algorithm #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested changes
Nov 15, 2023
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
requested changes
Nov 15, 2023
apasel422
requested changes
Nov 16, 2023
apasel422
requested changes
Nov 21, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 29, 2023
WICG/attribution-reporting-api#1111 But do not use them yet. This will make it easier to experiment with proofs-of-concept for Full Flex prioritization, e.g. crrev.com/c/5037210, after which we will start using these new functions in TriggerSpecs::Parse(). This change has no effect on web-visible behavior. OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError8]=Replaced by Conversions.SourceRegistrationError9 Bug: 1504219 Change-Id: I78fbcc62071a2b56051e07811ff5ded0d58b2e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5049377 Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Commit-Queue: Andrew Paseltiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1230803}
apasel422
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update with respect to #1116.
apasel422
added
the
flexible-event
Regarding the flexible event configuration proposal
label
Dec 1, 2023
apasel422
requested changes
Dec 1, 2023
apasel422
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the definition for summary window operator and summary bucket structure.
Preview | Diff